ionutzpi commented on code in PR #1526:
URL: https://github.com/apache/jackrabbit-oak/pull/1526#discussion_r1644492664
##########
oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyStateTest.java:
##########
@@ -81,4 +100,225 @@ public void multiValuedBinarySize() throws Exception {
assertEquals(0, reads.size());
}
-}
+ @Test
+ public void multiValuedAboveThresholdSize() throws Exception {
+ NodeBuilder builder = ns.getRoot().builder();
+ List<Blob> blobs = newArrayList();
+ for (int i = 0; i < 13; i++) {
+ blobs.add(builder.createBlob(new RandomStream(BLOB_SIZE, i)));
+ }
+ builder.child(TEST_NODE).setProperty("p", blobs, Type.BINARIES);
+ TestUtils.merge(ns, builder);
+
+ PropertyState p =
ns.getRoot().getChildNode(TEST_NODE).getProperty("p");
+ assertEquals(Type.BINARIES, Objects.requireNonNull(p).getType());
+ assertEquals(13, p.count());
+
+ reads.clear();
+ assertEquals(BLOB_SIZE, p.size(0));
+ // must not read the blob via stream
+ assertEquals(0, reads.size());
+ }
+
+ @Test
+ public void stringBelowThresholdSize() throws Exception {
+ NodeBuilder builder = ns.getRoot().builder();
+ builder.child(TEST_NODE).setProperty("p", "dummy", Type.STRING);
+ TestUtils.merge(ns, builder);
+
+ PropertyState p =
ns.getRoot().getChildNode(TEST_NODE).getProperty("p");
+ assertEquals(Type.STRING, Objects.requireNonNull(p).getType());
+ assertEquals(1, p.count());
+
+ reads.clear();
+ assertEquals(5, p.size(0));
+ // must not read the string via stream
+ assertEquals(0, reads.size());
+ }
+
+ @Test
+ public void stringAboveThresholdSize() throws Exception {
+ NodeBuilder builder = ns.getRoot().builder();
+ builder.child(TEST_NODE).setProperty("p", STRING_HUGEVALUE,
Type.STRING);
+ TestUtils.merge(ns, builder);
+
+ PropertyState p =
ns.getRoot().getChildNode(TEST_NODE).getProperty("p");
+ assertEquals(Type.STRING, Objects.requireNonNull(p).getType());
+ assertEquals(1, p.count());
+
+ reads.clear();
+ assertEquals(10050, p.size(0));
+ // must not read the string via streams
+ assertEquals(0, reads.size());
+ }
+
+ @Test
+ public void compressValueThrowsException() throws IOException,
NoSuchFieldException, IllegalAccessException {
+ DocumentNodeStore mockDocumentStore = mock(DocumentNodeStore.class);
+ Compression mockCompression = mock(Compression.class);
+
when(mockCompression.getOutputStream(any(OutputStream.class))).thenThrow(new
IOException("Compression failed"));
+
+ Field compressionThreshold =
DocumentPropertyState.class.getDeclaredField("DEFAULT_COMPRESSION_THRESHOLD");
+ compressionThreshold.setAccessible(true);
+ Field modifiersField = Field.class.getDeclaredField("modifiers");
+ modifiersField.setAccessible(true);
+ modifiersField.setInt(compressionThreshold,
compressionThreshold.getModifiers() & ~Modifier.FINAL);
+
+ compressionThreshold.set(null, DEFAULT_COMPRESSION_THRESHOLD);
+
+ DocumentPropertyState documentPropertyState = new
DocumentPropertyState(mockDocumentStore, "p", "\"" + STRING_HUGEVALUE + "\"",
mockCompression);
+
+ assertEquals(documentPropertyState.getValue(Type.STRING),
STRING_HUGEVALUE);
+
+ verify(mockCompression,
times(1)).getOutputStream(any(OutputStream.class));
+
+ compressionThreshold.set(null, -1);
+
+ }
+
+ @Test
+ public void uncompressValueThrowsException() throws IOException,
NoSuchFieldException, IllegalAccessException {
+
+ DocumentNodeStore mockDocumentStore = mock(DocumentNodeStore.class);
+ Compression mockCompression = mock(Compression.class);
+ OutputStream mockOutputStream= mock(OutputStream.class);
+
when(mockCompression.getOutputStream(any(OutputStream.class))).thenReturn(mockOutputStream);
+
when(mockCompression.getInputStream(any(InputStream.class))).thenThrow(new
IOException("Compression failed"));
+
+ Field compressionThreshold =
DocumentPropertyState.class.getDeclaredField("DEFAULT_COMPRESSION_THRESHOLD");
+ compressionThreshold.setAccessible(true);
+ Field modifiersField = Field.class.getDeclaredField("modifiers");
+ modifiersField.setAccessible(true);
+ modifiersField.setInt(compressionThreshold,
compressionThreshold.getModifiers() & ~Modifier.FINAL);
+
+ compressionThreshold.set(null, DEFAULT_COMPRESSION_THRESHOLD);
+
+ DocumentPropertyState documentPropertyState = new
DocumentPropertyState(mockDocumentStore, "p", STRING_HUGEVALUE,
mockCompression);
+
+ assertEquals(documentPropertyState.getValue(Type.STRING), "{}");
+
+ verify(mockCompression,
times(1)).getInputStream(any(InputStream.class));
+
+ compressionThreshold.set(null, -1);
+ }
+
+ @Test
+ public void adefaultValueSetToMinusOne() throws NoSuchMethodException,
InvocationTargetException, IllegalAccessException, NoSuchFieldException {
+ DocumentNodeStore store = mock(DocumentNodeStore.class);
+
+ DocumentPropertyState state = new DocumentPropertyState(store,
"propertyNameNew", "\"" + STRING_HUGEVALUE + "\"", Compression.GZIP);
+
+ // Get the private method
+ Method getCompressedValueMethod =
DocumentPropertyState.class.getDeclaredMethod("getCompressedValue");
+
+ // Make the method accessible
+ getCompressedValueMethod.setAccessible(true);
+ byte[] result = (byte[]) getCompressedValueMethod.invoke(state);
+
+ assertNull(result);
+ assertEquals(state.getValue(Type.STRING), STRING_HUGEVALUE);
+ }
+
+ @Test
+ public void stringAboveThresholdSizeNoCompression() throws
NoSuchMethodException, InvocationTargetException, IllegalAccessException,
NoSuchFieldException {
+ DocumentNodeStore store = mock(DocumentNodeStore.class);
+
+ // Get the private method
+ Method getCompressedValueMethod =
DocumentPropertyState.class.getDeclaredMethod("getCompressedValue");
+
+ // Make the method accessible
+ getCompressedValueMethod.setAccessible(true);
+
+ Field compressionThreshold =
DocumentPropertyState.class.getDeclaredField("DEFAULT_COMPRESSION_THRESHOLD");
+ compressionThreshold.setAccessible(true);
+ Field modifiersField = Field.class.getDeclaredField("modifiers");
+ modifiersField.setAccessible(true);
+ modifiersField.setInt(compressionThreshold,
compressionThreshold.getModifiers() & ~Modifier.FINAL);
+
+ compressionThreshold.set(null, DEFAULT_COMPRESSION_THRESHOLD);
+
+ DocumentPropertyState state = new DocumentPropertyState(store,
"propertyName", "\"" + STRING_HUGEVALUE + "\"", Compression.NONE);
+
+ byte[] result = (byte[]) getCompressedValueMethod.invoke(state);
+
+ assertEquals(result.length, STRING_HUGEVALUE.length() + 2 );
+
+ assertEquals(state.getValue(Type.STRING), STRING_HUGEVALUE);
+ assertEquals(STRING_HUGEVALUE, state.getValue(Type.STRING));
+
+ // Reset the value of the field
+ compressionThreshold.set(null, -1);
+ }
+
+ @Test(expected = ComparisonFailure.class)
+ public void testInterestingStrings() throws NoSuchFieldException,
IllegalAccessException {
+
+ DocumentNodeStore store = mock(DocumentNodeStore.class);
+ String testString = "\"\"simple:foo\", \"cr:a\\n\\b\",
\"dquote:a\\\"b\", \"bs:a\\\\b\", \"euro:a\\u201c\",
\"gclef:\\uD834\\uDD1E\",\n" +
+ " \"tab:a\\tb\", \"nul:a\\u0000b\",
\"brokensurrogate:\\ud800\"";
+
+ Field compressionThreshold =
DocumentPropertyState.class.getDeclaredField("DEFAULT_COMPRESSION_THRESHOLD");
+ compressionThreshold.setAccessible(true);
+ Field modifiersField = Field.class.getDeclaredField("modifiers");
+ modifiersField.setAccessible(true);
+ modifiersField.setInt(compressionThreshold,
compressionThreshold.getModifiers() & ~Modifier.FINAL);
+
+ compressionThreshold.set(null, 10);
+
+ DocumentPropertyState state = new DocumentPropertyState(store,
"propertyName", testString, Compression.GZIP);
+
+ String value = state.getValue(Type.STRING);
+
+ assertEquals(testString, value);
+
+ }
+
+ @Test
+ public void performanceTest() throws NoSuchFieldException,
IllegalAccessException {
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
