stefan-egli commented on code in PR #1526:
URL: https://github.com/apache/jackrabbit-oak/pull/1526#discussion_r1644787553
##########
oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyStateTest.java:
##########
@@ -60,6 +73,11 @@ public void before() throws Exception {
ns = builderProvider.newBuilder().setBlobStore(bs).getNodeStore();
}
+ @After
+ public void tearDown() {
+ ns.dispose();
Review Comment:
```suggestion
try {
ns.dispose();
} finally {
DocumentPropertyState.setCompressionThreshold(DISABLED_COMPRESSION);
}
```
to avoid side-effects, the test should ensure it doesn't leak a non default
compression threshold to other tests. DISABLED_COMPRESSION is for illustration
to refer to -1 - ideally the -1 would only be defined in the source class...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
