rishabhdaim commented on code in PR #1745:
URL: https://github.com/apache/jackrabbit-oak/pull/1745#discussion_r1778513661
##########
oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/MissingLastRevSeekerTest.java:
##########
@@ -249,7 +251,7 @@ public void dispose() {
}
dns.runBackgroundOperations();
//seeker should return only non split documents
- int docs = Iterables.size(seeker.getCandidates(0));
+ int docs =
Iterables.size(seeker.getCandidates(Objects.requireNonNull(dns.getRoot().getLastRevision().getRevision(dns.getClusterId())).getTimestamp()));
Review Comment:
`0` was used to fetch all the documents. Using the timestamp of lastRevision
would result in skipping some documents.
If there is no proper reason, I will revert the change.
##########
oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/MissingLastRevSeekerTest.java:
##########
@@ -249,7 +251,7 @@ public void dispose() {
}
dns.runBackgroundOperations();
//seeker should return only non split documents
- int docs = Iterables.size(seeker.getCandidates(0));
+ int docs =
Iterables.size(seeker.getCandidates(Objects.requireNonNull(dns.getRoot().getLastRevision().getRevision(dns.getClusterId())).getTimestamp()));
Review Comment:
`0` was used to fetch all the documents. Using the timestamp of
`lastRevision` would result in skipping some documents.
If there is no proper reason, I will revert the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
