ionutzpi commented on code in PR #1745:
URL: https://github.com/apache/jackrabbit-oak/pull/1745#discussion_r1778622085
##########
oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/MissingLastRevSeekerTest.java:
##########
@@ -249,7 +251,7 @@ public void dispose() {
}
dns.runBackgroundOperations();
//seeker should return only non split documents
- int docs = Iterables.size(seeker.getCandidates(0));
+ int docs =
Iterables.size(seeker.getCandidates(Objects.requireNonNull(dns.getRoot().getLastRevision().getRevision(dns.getClusterId())).getTimestamp()));
Review Comment:
Yes. That is the reason that I modified the timestamp to return only the
documents needed, not all documents.
@reschke we can have inconsistencies retrieving all docs from RDB, but
retrieving only the ones that this test added should solve the issue and future
issues that could appear regarding this test. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
