shodaaan commented on code in PR #1795:
URL: https://github.com/apache/jackrabbit-oak/pull/1795#discussion_r1804590938
##########
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/Configuration.java:
##########
@@ -353,4 +353,24 @@
"FullGC can be entirely enabled / disabled with the
variable fullGCEnabled, unless fullGCEnabled " +
"is set to true, the fullGCMode will be ignored.")
int fullGCMode() default DEFAULT_FULL_GC_MODE;
+
+ @AttributeDefinition(
+ name = "Delay factor for a Full GC run",
+ description = "A Full GC run has a gap of this delay factor to
reduce continuous load on system." +
+ "It allows the FullGC thread to stop by (fullGC run time *
delayFactor) period after each cycle." +
+ "The default value is " +
DocumentNodeStoreService.DEFAULT_FGC_DELAY_FACTOR)
+ double fullGCDelayFactor() default
DocumentNodeStoreService.DEFAULT_FGC_DELAY_FACTOR;
+
+ @AttributeDefinition(
+ name = "Batch Size to fetch data for each FullGC cycle",
+ description = "Integer value indicating the number of documents to
fetch from database in a single query to check for Full GC." +
+ "It should be a factor of fullGCProgressSize for better
performance " +
+ "The default value is " +
DocumentNodeStoreService.DEFAULT_FGC_BATCH_SIZE)
+ int fullGCBatchSize() default
DocumentNodeStoreService.DEFAULT_FGC_BATCH_SIZE;
Review Comment:
Suggested change: for more clarity this could be renamed to
"fullGCFetchBatchSize" or "fullGCFetchDocsBatchSize"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
