stefan-egli commented on code in PR #1795:
URL: https://github.com/apache/jackrabbit-oak/pull/1795#discussion_r1806194852
##########
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java:
##########
@@ -255,26 +259,33 @@ static void setFullGcMode(int fullGcMode) {
final boolean fullGCEnabled,
final boolean isFullGCDryRun,
final boolean embeddedVerification) {
- this(nodeStore, gcSupport, fullGCEnabled, isFullGCDryRun,
embeddedVerification,
- DocumentNodeStoreService.DEFAULT_FULL_GC_MODE);
+ this(nodeStore, gcSupport, fullGCEnabled, isFullGCDryRun,
embeddedVerification, DEFAULT_FULL_GC_MODE,
+ 0, DEFAULT_FGC_BATCH_SIZE, DEFAULT_FGC_PROGRESS_SIZE);
}
VersionGarbageCollector(DocumentNodeStore nodeStore,
VersionGCSupport gcSupport,
final boolean fullGCEnabled,
final boolean isFullGCDryRun,
final boolean embeddedVerification,
- final int fullGCMode) {
+ final int fullGCMode,
+ final double fullGCDelayFactor,
+ final int fullGCBatchSize,
+ final int fullGCProgressSize) {
this.nodeStore = nodeStore;
this.versionStore = gcSupport;
this.ds = gcSupport.getDocumentStore();
this.fullGCEnabled = fullGCEnabled;
this.isFullGCDryRun = isFullGCDryRun;
this.embeddedVerification = embeddedVerification;
+ this.fullGCDelayFactor = fullGCDelayFactor;
+ this.fullGCBatchSize = Math.min(fullGCBatchSize, fullGCProgressSize);
+ this.fullGCProgressSize = fullGCProgressSize;
this.options = new VersionGCOptions();
setFullGcMode(fullGCMode);
- AUDIT_LOG.info("<init> VersionGarbageCollector created with fullGcMode
= {}", fullGcMode);
+ AUDIT_LOG.info("<init> VersionGarbageCollector created with
fullGcMode: {}, batchSize: {}, progressSize: {}",
+ fullGcMode, fullGCBatchSize, fullGCProgressSize);
Review Comment:
minor : could also log `delayFactor` (but would suggest to merge the PR
anyway)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
