mreutegg commented on code in PR #2467:
URL: https://github.com/apache/jackrabbit-oak/pull/2467#discussion_r2293763855
##########
oak-segment-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureArchiveManager.java:
##########
@@ -80,38 +80,16 @@ public AzureArchiveManager(BlobContainerClient
readBlobContainerClient, BlobCont
@Override
public List<String> listArchives() throws IOException {
try {
- List<String> archiveNames =
readBlobContainerClient.listBlobsByHierarchy(rootPrefix).stream()
+ return
readBlobContainerClient.listBlobsByHierarchy(rootPrefix).stream()
Review Comment:
This method now returns empty archives. This is probably OK, but the code in
trunk also filters out and attempts to delete archives that were in the process
of being deleted and got interrupted. IIUC,
`AzureArchiveManager.delete(String)` lists blobs in the archive and deletes
them in that sequence. When interrupted, the first segment starting with `0000`
has likely been deleted, hence `isArchiveEmpty()` returns `true`. This means
`listArchives()` now also returns half-deleted archives. Isn't this a problem?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
