smiroslav commented on code in PR #2467:
URL: https://github.com/apache/jackrabbit-oak/pull/2467#discussion_r2293928958
##########
oak-segment-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureArchiveManager.java:
##########
@@ -80,38 +80,16 @@ public AzureArchiveManager(BlobContainerClient
readBlobContainerClient, BlobCont
@Override
public List<String> listArchives() throws IOException {
try {
- List<String> archiveNames =
readBlobContainerClient.listBlobsByHierarchy(rootPrefix).stream()
+ return
readBlobContainerClient.listBlobsByHierarchy(rootPrefix).stream()
Review Comment:
The code in `trunk` right now assumes the archive is empty if the segment
"0000.*" is absent.
If we do filtering based on that, the question is how to distinguish
intentional archive deletion from data corruption, when a segment is deleted or
not successfully uploaded for any reason.
Let's handle archive deletion in a separate task, where we could signal
intent with a special blob ("deleted" marker), which we can use for filtering.
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
