rishabhdaim commented on code in PR #3259:
URL: https://github.com/apache/jackrabbit-oak/pull/3259#discussion_r4476185762


##########
oak-search-elastic/pom.xml:
##########
@@ -59,6 +59,8 @@
               org.apache.jackrabbit.oak.plugins.index.elastic.util
             </Export-Package>
             <Import-Package>
+              <!-- Embedded Commons Logging uses LocationAwareLogger in both 
SLF4J generations. -->
+              org.slf4j.spi;version="[1.7,3)",

Review Comment:
   Agreed that SLF4J does not guarantee compatibility for the entire SPI 
package; this exception preserves the embedded [Commons Logging 1.3.5 bundle's 
own optional `[1.7,3)` SPI 
import](https://github.com/apache/commons-logging/blob/rel/commons-logging-1.3.5/pom.xml#L69-L71).
 
   
   In 
[110fe7d0c0](https://github.com/apache/jackrabbit-oak/commit/110fe7d0c0fc4cfda282ae4ffa964da3d4f359ff),
 I clarified the POM comment and changed the test to use `LogFactory.getLog` 
with the real OSGi provider, checking enabled/disabled levels, throwable 
identity and caller location: all 9 OSGi tests pass on both SLF4J 1.7.36 / 
Logback 1.2.13 and SLF4J 2.0.20 / Logback 1.6.4, while removing the override 
reproduces two `LocationAwareLogger` loading errors.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to