kwin commented on code in PR #3259:
URL: https://github.com/apache/jackrabbit-oak/pull/3259#discussion_r4470032777


##########
oak-search-elastic/pom.xml:
##########
@@ -59,6 +59,8 @@
               org.apache.jackrabbit.oak.plugins.index.elastic.util
             </Export-Package>
             <Import-Package>
+              <!-- Embedded Commons Logging uses LocationAwareLogger in both 
SLF4J generations. -->
+              org.slf4j.spi;version="[1.7,3)",

Review Comment:
   `org.slf4j.spi` is **not** backwards compatible, only `org.slf4j`. Widening 
the import version range doesn't make it magically backwards compatible either. 
That the test don't run into issues probably just proofs that they are not 
complete. See discussion at https://github.com/qos-ch/slf4j/pull/358 and 
https://jira.qos.ch/browse/SLF4J-579. 
   Particularly pay attention to
   
   > The package-info for org.slf4j.spi states that this package should not be 
used by clients.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to