[ 
https://issues.apache.org/jira/browse/OAK-464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13526255#comment-13526255
 ] 

Thomas Mueller commented on OAK-464:
------------------------------------

> Well this will be a performance bottleneck I'm pretty sure.

When and why would it be a performance bottleneck? In my view, the real 
performance bottleneck is to first create a branch, then commit to the branch, 
then merge the branch (3 MicroKernel calls instead of just one, which is: 
commit). Plus, I still don't understand why the RootImpl.rebase operation 
requires any MicroKernel calls at all.

As I already wrote, why doesn't oak-core keep track of the list of operations?

> than duplicating code

As I already wrote, implementing it once in oak-core is _not_ duplicating code. 
Implementing it in _each_ MicroKernel implementation separately is duplicating 
code.

                
> RootImpl.rebase() doesn't handle move operations correctly
> ----------------------------------------------------------
>
>                 Key: OAK-464
>                 URL: https://issues.apache.org/jira/browse/OAK-464
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>            Reporter: Michael Dürig
>
> Doing {{RootImpl.rebase()}} causes moves to be changed to remove followed by 
> add. Which causes moves of large sub trees to become very expensive.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to