[ 
https://issues.apache.org/jira/browse/OAK-464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13526271#comment-13526271
 ] 

Thomas Mueller commented on OAK-464:
------------------------------------

I would still get answers for my questions: 

> Well this will be a performance bottleneck I'm pretty sure.

When and why would it be a performance bottleneck? In my view, the real 
performance bottleneck is to first create a branch, then commit to the branch, 
then merge the branch (3 MicroKernel calls instead of just one, which is: 
commit). Plus, I still don't understand why the RootImpl.rebase operation 
requires any MicroKernel calls at all. Isn't this in fact the real performance 
problem?

Is keeping track of the list of operations in oak-core not anyway require for 
observation to work correctly? Or don't we want to support move operations in 
observation?

> This is a architectural decision which was discussed at length, and which you 
> should be aware of.

I'm aware this is what you and Jukka decided, but it seems to me there are more 
and more problems with this approach, as we see now. In fact I never really 
understood the reasons for that decision. I also never understood why branch 
and merge would be needed except for operations that don't fit in memory.


                
> RootImpl.rebase() doesn't handle move operations correctly
> ----------------------------------------------------------
>
>                 Key: OAK-464
>                 URL: https://issues.apache.org/jira/browse/OAK-464
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>            Reporter: Michael Dürig
>
> Doing {{RootImpl.rebase()}} causes moves to be changed to remove followed by 
> add. Which causes moves of large sub trees to become very expensive.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to