[
https://issues.apache.org/jira/browse/OAK-3791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15098099#comment-15098099
]
Marcel Reutegger commented on OAK-3791:
---------------------------------------
Looks very good to me. One question about the screenshot. Why do all the types
have an oak prefix?
It would also be nice to have stats about how long it took to acquire one of
the nodeLocks. The current patch includes the time to acquire the lock for a
given uncached call. I would probably keep it that way, to get an accurate
picture of the overall time to perform the operation, but additional lock stats
would also be nice.
Stats for other methods like remove are missing. Wouldn't it be better to add
those as well?
> Time measurements for DocumentStore methods
> -------------------------------------------
>
> Key: OAK-3791
> URL: https://issues.apache.org/jira/browse/OAK-3791
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: core, documentmk
> Reporter: Teodor Rosu
> Assignee: Chetan Mehrotra
> Fix For: 1.4
>
> Attachments: OAK-3791-RDB-0.patch, OAK-3791-v1.patch,
> OAK-3791-v2-chetanm.patch, oak-document-stats.png
>
>
> For monitoring ( in big latency environments ), it would be useful to measure
> and report time for the DocumentStore methods.
> These could be exposed as (and/or):
> - as Timers generated obtained from StatisticsProvider ( statistics registry )
> - as TimeSeries
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
