[ 
https://issues.apache.org/jira/browse/OAK-3791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15101635#comment-15101635
 ] 

Chetan Mehrotra commented on OAK-3791:
--------------------------------------

bq.  One question about the screenshot. Why do all the types have an oak prefix?

The screenshot is from a WebConsole plugin which is implemented as part of 
SLING-4080. It includes the "name" of {{Metricregistry}} to which the metric 
belongs. For {{MetricRegistry}} registered by Oak we set the name to 'oak'

bq. It would also be nice to have stats about how long it took to acquire one 
of the nodeLocks. 

Missed that. Have exposed a meter for that

bq. Stats for other methods like remove are missing. Wouldn't it be better to 
add those as well?

I thought about that. However remove is only invoked from VersionGC and there 
we capture overall rich stats. So that not that important for now. Would add it 
later



> Time measurements for DocumentStore methods
> -------------------------------------------
>
>                 Key: OAK-3791
>                 URL: https://issues.apache.org/jira/browse/OAK-3791
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core, documentmk
>            Reporter: Teodor Rosu
>            Assignee: Chetan Mehrotra
>             Fix For: 1.4
>
>         Attachments: OAK-3791-RDB-0.patch, OAK-3791-v1.patch, 
> OAK-3791-v2-chetanm.patch, OAK-3791-v3-rdb.patch, oak-document-stats.png
>
>
> For monitoring ( in big latency environments ), it would be useful to measure 
> and report time for the DocumentStore methods.
> These could be exposed as (and/or):
> - as Timers generated obtained from StatisticsProvider ( statistics registry )
> - as TimeSeries 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to