[ 
https://issues.apache.org/jira/browse/OAK-5878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15899243#comment-15899243
 ] 

Julian Reschke commented on OAK-5878:
-------------------------------------

So this change change will only affect RDBDocumentStore, for which it is a 
quick win, reducing the number of table scans for ´VGC from 3 to 2.

Even if we do something fancier for OAK-5855, this change will be simple to 
backport all the way back to 1.0.

So I'd propose to apply this to trunk, and gradually port it back to earlier 
branches...

> SplitDocumentCleanup iterates twice over splitDocGarbage
> --------------------------------------------------------
>
>                 Key: OAK-5878
>                 URL: https://issues.apache.org/jira/browse/OAK-5878
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: documentmk
>            Reporter: Julian Reschke
>            Assignee: Julian Reschke
>         Attachments: OAK-5878.diff
>
>
> {{SplitDocumentCleanup}} currently iterates twice over {{splitDocGarbage}}.
> NOTE: not the case for Mongo DB, as {{MongoVersionGCSupport}} overwrites 
> {{deleteSplitDocuments()}}.
> {{deleteSplitDocuments()}} currently iterates over {{splitDocGarbage}} to 
> obtain the IDs of the documents to be deleted. Instead, we could just collect 
> the IDs inside {{disconnect()}}, the memory requirements would be the same.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to