[ https://issues.apache.org/jira/browse/OAK-5878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15899463#comment-15899463 ]
Julian Reschke commented on OAK-5878: ------------------------------------- trunk: [r1785838|http://svn.apache.org/r1785838] > SplitDocumentCleanup iterates twice over splitDocGarbage > -------------------------------------------------------- > > Key: OAK-5878 > URL: https://issues.apache.org/jira/browse/OAK-5878 > Project: Jackrabbit Oak > Issue Type: Bug > Components: documentmk > Reporter: Julian Reschke > Assignee: Julian Reschke > Labels: candidate_oak_1_0, candidate_oak_1_2, candidate_oak_1_4, > candidate_oak_1_6 > Fix For: 1.7.0, 1.8 > > Attachments: OAK-5878-2.diff, OAK-5878.diff > > > {{SplitDocumentCleanup}} currently iterates twice over {{splitDocGarbage}}. > NOTE: not the case for Mongo DB, as {{MongoVersionGCSupport}} overwrites > {{deleteSplitDocuments()}}. > {{deleteSplitDocuments()}} currently iterates over {{splitDocGarbage}} to > obtain the IDs of the documents to be deleted. Instead, we could just collect > the IDs inside {{disconnect()}}, the memory requirements would be the same. -- This message was sent by Atlassian JIRA (v6.3.15#6346)