[ https://issues.apache.org/jira/browse/OAK-6020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15953576#comment-15953576 ]
Marcel Reutegger commented on OAK-6020: --------------------------------------- Hmm, related to Vikas comment, wouldn't it be better to use a predefined Locale? The current patch uses the default Locale, which is platform specific. This means the test may fail if the default locale does not use the comma character as a separator but something else. The test is also in the default package. Sorry, didn't notice when I looked at the patch the first time... > add a Guava Stopwatch like duration formatter > --------------------------------------------- > > Key: OAK-6020 > URL: https://issues.apache.org/jira/browse/OAK-6020 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: commons > Reporter: Julian Reschke > Assignee: Julian Reschke > Priority: Minor > Labels: candidate_oak_1_0, candidate_oak_1_2, candidate_oak_1_4, > candidate_oak_1_6 > Attachments: OAK-6020.diff > > > The duration formatter in {{com.google.common.base.Stopwatch}} can only be > sued when we indeed have a {{Stopwatch}} object, which is not always the case. > {{org.apache.jackrabbit.oak.management.ManagementOperation}} has similar code > already. > Proposal: move that code into a separate generic class. -- This message was sent by Atlassian JIRA (v6.3.15#6346)