[ https://issues.apache.org/jira/browse/OAK-6450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16096280#comment-16096280 ]
Robert Munteanu commented on OAK-6450: -------------------------------------- [~anchela] - thank you for the review. {quote} why are the RegistrationConstants located in org.apache.jackrabbit.oak.security.authorization package? that looks wrong to me as it is used also in non-authorization packages.{quote} You're right, that does look a bit off. I did not find a proper place for it, but {{org.apache.jackrabbit.oak.spi.security}} looks good and I'll move the class there. When we split off the security.spi packages to a separate module it will be moved with all otehr classes. {quote} i am not sure about the PN prefix with the RegistrationConstants. what does it stand for?{quote} It stands for property name and I hoped it would be explicit. Apparently it's not :-) so I'll drop it. I'll also take care of testing and documentation in the next revision of the patch. > Stop relying on the service.pid property in SecurityProviderRegistration > ------------------------------------------------------------------------ > > Key: OAK-6450 > URL: https://issues.apache.org/jira/browse/OAK-6450 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: security > Reporter: Robert Munteanu > Assignee: Robert Munteanu > Fix For: 1.8, 1.7.5 > > Attachments: > 0001-OAK-6450-Stop-relying-on-the-service.pid-property-in.patch, > 0002-OAK-6450-Stop-relying-on-the-service.pid-property-in.patch > > > As discussed in OAK-6111, we should stop relying on the {{service.pid}} OSGi > property for tracking required services as it was incorrectly set so far by > the {{maven-scr-plugin}}. -- This message was sent by Atlassian JIRA (v6.4.14#64029)