lør, 13 06 2009 kl. 07:31 -0500, skrev dmelliott: > Is this guy ever going to get it right?
:-) I'm sorry to keep bringing up small issues -- I truly hope this doesn't scare you from contributing. That being said I have three comments 1) In the license you write: "This file is distributed with Octave." This is not true. When we add the function to a package it will be distributed with the package, which is not "Octave". This is just a minor detail, but the line should be removed. 2) I still do not think the 'test_integ1es' function should be included. It seems like a demonstration to me, and not a function anybody would be using in their own programs. Is this true, or am I missing something? If it is true, then it would be better to add the example as a demo. We already have too many '_test' functions in various packages. These are but a remedy of old days. 3) You do not need to add semi-colons after keywords such as 'endif', 'endfunction', etc. I don't care if you add or remove these semi-colons, I just thought you should know that you do not need them :-) Other than these minor issues, I think your code looks good. Thanks for doing this :-) Søren ------------------------------------------------------------------------------ Crystal Reports - New Free Runtime and 30 Day Trial Check out the new simplified licensing option that enables unlimited royalty-free distribution of the report engine for externally facing server and web deployment. http://p.sf.net/sfu/businessobjects _______________________________________________ Octave-dev mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/octave-dev
