Dear Søren,

    Please feel more than free to bring up any issue of compliance. 
Learning how to do this was my goal for this submission.  Having been, among 
many other things, a QA Manager, I am quite sensitive to document control, 
and understand the importance of document uniformity.  Please feel totally 
free, especially with my terrible spelling, and poor typing.

1)  Gone.  Need incorrectly assumed.  Does the 'help' work for you in the 
last submission?


3)  I understand the lack of requirement.  I use it just because I find it 
helpful to myself.  Also gone.


2)  Finally found the 'demo' documentation, sorry.  Will get back to you on 
this.


    Question about these E-Mails.  I keep changing them to 'plain text' 
because of a poor looking "Help" posting I once had, and trying to chop 
things off at 80 characters.  Besides finding this something of a bother, I 
can't believe that people are not using one of the many, free E-Mail 
programs that do perfectly well with HTML (even if the forum doesn't).  Can 
I stop doing this?


                                                                             
                Yours truly,

                                                                             
                        dmelliott




----- Original Message ----- 
From: Søren Hauberg
To: dmelliott
Cc: [email protected]
Sent: Saturday, June 13, 2009 3:50 PM
Subject: Re: [OctDev] Developer Registration Request


lør, 13 06 2009 kl. 07:31 -0500, skrev dmelliott:
> Is this guy ever going to get it right?

:-)

I'm sorry to keep bringing up small issues -- I truly hope this doesn't
scare you from contributing. That being said I have three comments

1) In the license you write: "This file is distributed with Octave."
   This is not true. When we add the function to a package it will be
   distributed with the package, which is not "Octave". This is just a
   minor detail, but the line should be removed.

2) I still do not think the 'test_integ1es' function should be included.
   It seems like a demonstration to me, and not a function anybody would
   be using in their own programs. Is this true, or am I missing
   something? If it is true, then it would be better to add the example
   as a demo. We already have too many '_test' functions in various
   packages. These are but a remedy of old days.

3) You do not need to add semi-colons after keywords such as 'endif',
   'endfunction', etc. I don't care if you add or remove these
   semi-colons, I just thought you should know that you do not need
   them :-)

Other than these minor issues, I think your code looks good. Thanks for
doing this :-)

Søren 


------------------------------------------------------------------------------
Crystal Reports - New Free Runtime and 30 Day Trial
Check out the new simplified licensing option that enables unlimited
royalty-free distribution of the report engine for externally facing 
server and web deployment.
http://p.sf.net/sfu/businessobjects
_______________________________________________
Octave-dev mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/octave-dev

Reply via email to