On 8 Nov 2011, at 15:12, Carlo de Falco wrote: > Michele, > > This sounds indeed like a nice contribution! > > I might try to help check the code but currently > I really have very little spare time, so if someone else > jumps in it would defenitely make things happen faster. > > Anyway here is a few quick comments: > > I see in the DESCRIPTION file: > > License: LGPL, see individual files for GPL version > > Do you intend to use GPL or LGPL? > > I think for m-files and for c files that do not link to Octave internals you > can use whatever you like, > but any .oct file will link to Octave internals so, as Octave is GPLv3, it > must be GPLv3 as well. > > On 8 Nov 2011, at 13:00, Michele Martone wrote: > >> Essentially, the "librsb" library is almost ready for a release and it >> only needs more "early users" for a wider testing. >> The "sparsersb" Octave plugin/type is quite functional, although I think >> some expert Octave developer should give a look at it --- I am not even >> sure how much it is "legal" to introduce a new Octave type by mimicking >> the Octave internals/headers (as I did). > > There is an example of the correct way to create a new octave matrix class in > the package "triangular": > > http://octave.svn.sourceforge.net/viewvc/octave/trunk/octave-forge/extra/triangular/ > > >> I am not even sure whether/how much having OpenMP usage from within >> librsb is safe in the wider context of Octave. > > liboctave is not (yet) thread safe, so if you access liboctave class methods > from within the > parallel section of your code that might create issues, but if you only use > classes defined by > yourself it should work ... > > c.
Also, when I try to install with "pkg install sparsersb.tgz " I get a n error for a missing header: >> pkg install sparsersb.tgz skipping line ./configure: line 3298: librsb-config: command not found ./configure: line 3299: librsb-config: command not found sparsersb.cc:45:17: error: rsb.h: No such file or directory to have an example of how to set compilation flags in a package you can have a look at the configure script in "odepkg" or if you just need to set the location of one header file you could have a look at how this is done in "geopdes_base": http://sourceforge.net/projects/geopdes/ http://geopdes.svn.sourceforge.net/viewvc/geopdes/trunk/geopdes_base/pre_install.m?revision=433&view=markup c. ------------------------------------------------------------------------------ RSA(R) Conference 2012 Save $700 by Nov 18 Register now http://p.sf.net/sfu/rsa-sfdev2dev1 _______________________________________________ Octave-dev mailing list Octave-dev@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/octave-dev
