[ http://issues.apache.org/jira/browse/OFBIZ-540?page=comments#action_12457466 ] David E. Jones commented on OFBIZ-540: --------------------------------------
Just a few comments Ashish/Anil: - create methods should use a "create" prefix instead of an "add" prefix, and request names that call service should generally use the name of the service (unless there is a conflict or something, then adding context info is good); there are some bad examples in OFBiz, so the place to look for patterns is the example component; for form names the prefix "Add" is fine as we've used the different words to make a distinction between what they are used for; anyway, create matches up with update and delete better Actually, that was the only one. I haven't tested this yet (not sure if you're done yet or not), but this is certainly going in the right direction. If this is what you had in mind for a final patch let me know and I'll test and commit. Otherwise I'll wait for your final patch. > Services and Screens WorkEffortReview, WorkEffortContent, and > WorkEffortGoodStandard > ------------------------------------------------------------------------------------ > > Key: OFBIZ-540 > URL: http://issues.apache.org/jira/browse/OFBIZ-540 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: workeffort > Reporter: Anil K Patel > Attachments: Generic_Entity_Screen_2.patch > > > Creat generic administration screens and services for 3 entities that are > related to the WorkEffort. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
