[ http://issues.apache.org/jira/browse/OFBIZ-540?page=comments#action_12457578 ] David E. Jones commented on OFBIZ-540: --------------------------------------
This patch is a good start, so I'm committing it, but these still needs a few cleanups: 1. there are various Delete button texts with [] around them 2. on the list forms wherever there is an ID that points to an entity with a name field on it, it should also lookup and show that name (using display-entity, make the link with the sub hyperlink tag); these are missing on the WorkEffort->Content, WorkEffort->Good Standard, Content->Work Effort, Product->Work Effort; also on Work Effort->Review the userLoginId should link to the profile page in the Party Manager app using the UserLogin.partyId field, and it should show the party name to using the PartyNameView as is done elsewhere (search for PartyNameView to find examples) 3. the button title for Work Effort -> Good Standard shoud be Product instead of Good Standard (easier for the user, the whole Good Standard thing came from the entity name in the data model resource book) 4. the various *TypeId fields are showing the actual IDs and should show the description from the type table using the display-entity type of field 5. the statusId for the WorkEffortGoodStandard is using the general WorkEffort statuses but should use the statuses for WorkEffortGoodStandard defined in the WorkEffortTypeData.xml file Okay, I think that's about it. Things look pretty good, even with the test data I have for the client that is sponsoring this. > Services and Screens WorkEffortReview, WorkEffortContent, and > WorkEffortGoodStandard > ------------------------------------------------------------------------------------ > > Key: OFBIZ-540 > URL: http://issues.apache.org/jira/browse/OFBIZ-540 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: workeffort > Reporter: Anil K Patel > Assigned To: David E. Jones > Attachments: Generic_Entity_Screen_2.patch, > WorkEffortScreenAndServices.patch, WorkEffortScreenAndServicesUpdate3.patch > > > Creat generic administration screens and services for 3 entities that are > related to the WorkEffort. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
