Hello Denis, On 03/21/2012 02:09 AM, Denis Kenzior wrote:
static inline void get_query_next_cf_cond(struct ofono_call_forwarding *cf) @@ -565,7 +564,9 @@ static DBusMessage *cf_get_properties(DBusConnection *conn, DBusMessage *msg,cf->pending = dbus_message_ref(msg); cf->query_next = 0; - + cf->query_end = is_cfu_enabled(cf) ? + CALL_FORWARDING_TYPE_UNCONDITIONAL : + CALL_FORWARDING_TYPE_NOT_REACHABLE; get_query_next_cf_cond(cf); return NULL;What if we're running GetProperties for the first time and CFU is active at the network, but for some reason (e.g. driver doesn't implement it) the SIM call forwarding rules are absent. Won't we query conditional CFs needlessly here?
Good point and thanks for pointing this. I will correct so, that once the CFU is discovered and active, the conditional queries will be skipped.
Regards, Oleg -- Intel Finland Oy Registered Address: PL 281, 00181 Helsinki Business Identity Code: 0357606 - 4 Domiciled in Helsinki _______________________________________________ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono
