Thanks do you think that you can submit it to ofono mailing list?
in particular I don;t know if if (data->model == ME910C1) ofono_netreg_create(modem, OFONO_VENDOR_TELIT_ME910C1, "atmodem", data->chat); else ofono_netreg_create(modem, OFONO_VENDOR_TELIT, "atmodem", data->chat); is acceptable Cheers Nicola Lunghi On Wed, 2 Oct 2019 at 15:29, Anibal Limón <limon.ani...@gmail.com> wrote: > > > On Wed, Oct 2, 2019 at 9:00 AM nick83ola <nick83...@gmail.com> wrote: > >> Hi Anibal, >> I'm interested as well in the patch >> >> I saw that there you have two branches (me910 and v1.30+me910) can you >> tell me what branch have you tested? >> the diff is this >> > > Yeah the latest one is me910, I was making a mistake to enable GPRS > instead of disable it, that's the change. > > Anibal > > >> >> git diff me910 >> diff --git a/plugins/telit.c b/plugins/telit.c >> index f36995dc..50344281 100644 >> --- a/plugins/telit.c >> +++ b/plugins/telit.c >> @@ -239,16 +239,19 @@ static void cfun_enable_cb(gboolean ok, GAtResult >> *result, gpointer user_data) >> >> ofono_modem_set_powered(modem, TRUE); >> >> - /* >> - * Tell the modem not to automatically initiate auto-attach >> - * proceedures on its own. >> - */ >> - if (data->model == ME910C1) >> - g_at_chat_send(data->chat, "AT+CGATT=0", NULL, NULL, >> NULL, NULL); >> - else >> - >> + if (data->model == ME910C1) { >> + /* >> + * Telit ME910C1 needs to activate the GPRS to >> auto-attach the network. >> + */ >> + g_at_chat_send(data->chat, "AT+CGATT=1", NULL, NULL, >> NULL, NULL); >> + } else { >> + /* >> + * Tell the modem not to automatically initiate >> auto-attach >> + * proceedures on its own. >> + */ >> g_at_chat_send(data->chat, "AT#AUTOATT=0", none_prefix, >> NULL, NULL, NULL); >> + } >> >> /* Follow sim state */ >> g_at_chat_register(data->chat, "#QSS:", telit_qss_notify, >> >> >> Thanks >> Nicola Lunghi >> >> >> On Tue, 1 Oct 2019 at 22:54, <limon.ani...@gmail.com> wrote: >> >>> Hi Dresdo, >>> >>> I have a patch that adds support for Telit ME910 but it is upon Ofono >>> 1.30, i plan to send for review. >>> >>> >>> https://github.com/alimon/ofono/commit/920712e184ffaf1143e9ce13c3bec8ac1deeda5c >>> >>> Regards!, >>> Anibal >>> _______________________________________________ >>> ofono mailing list -- ofono@ofono.org >>> To unsubscribe send an email to ofono-le...@ofono.org >>> >>
_______________________________________________ ofono mailing list -- ofono@ofono.org To unsubscribe send an email to ofono-le...@ofono.org