It's not too late to add a bit to allow targeting dead, but it would (ideally) call for translation of Target Class to a new data field, not so trivial.
Oh, I'd forgotten that "All including dead" was a recent addition, so I wouldn't worry about it. Of the old target classes "Ally including dead" was the only one which could target jumping heroes and likely to be used for spread attacks. I think that's the only case where there's a notable backcompat risk. If such an attack is used just for healing the party, it's not game-breaking (it just means that the player has to play the game a little differently). I was just concerned about such attacks used for battlescripting purposes to hit all heroes. But the fact that it has to be used by a hero (and hero counterattacks are very recent) makes that very unlikely. So I'll conclude that it's fine. On Mon, 17 Jan 2022 at 04:00, James Paige <[email protected]> wrote: > Yeah, I like the idea of a separate bit to allow an attack to target > hidden. > > I wish we had thought of that for "including dead", but oh well! :D > > On Sat, Jan 15, 2022 at 11:56 PM Ralph Versteegen <[email protected]> > wrote: > >> Of course maybe rather than adding even more target classes (a complete >> set would nearly double the current number!) we should just add a setting >> for whether hidden targets are valid. >> >> On Sun, 16 Jan 2022 at 17:51, Ralph Versteegen <[email protected]> >> wrote: >> >>> It took me some code inspection to work out that this is bug 1120 >>> https://github.com/ohrrpgce/ohrrpgce/issues/1120 "Heroes which have >>> jumped/in midair count as dead for targetting" (which I renamed to >>> something more generic before realising it's fixed). So it affects only >>> attacks that can hit dead targets (which are always heroes), not attacks by >>> heroes. >>> >>> Previously, attacks which can target all combatants or all heroes >>> (especially spread attacks) could also hit jumped targets, not anymore >>> after this fix. That seems like a big change; I suggest we add a back >>> compat bit. Also, I think we really need some target classes for hitting >>> hidden targets. We could also change the description of some of the >>> existing ones to say that they can hit hidden targets, e.g. "All including >>> dead & hidden", which I did last time I realised the names were inaccurate. >>> >>> On Sun, 16 Jan 2022 at 04:15, <[email protected]> wrote: >>> >>>> james >>>> 2022-01-15 07:15:38 -0800 (Sat, 15 Jan 2022) >>>> 96 >>>> Fix "Jump" (and the other new hiding attacks) to properly prevent >>>> targetting when used by heroes >>>> --- >>>> U wip/bmodsubs.bas >>>> U wip/whatsnew.txt >>>> >>>> _______________________________________________ >>>> Ohrrpgce mailing list >>>> [email protected] >>>> http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org >>>> >>> _______________________________________________ >> Ohrrpgce mailing list >> [email protected] >> http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org >> > _______________________________________________ > Ohrrpgce mailing list > [email protected] > http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org >
_______________________________________________ Ohrrpgce mailing list [email protected] http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org
