OK, I think I've gotten to the bottom of it. Can you pull this patch and try it on your end? If it seems to fix things, I'll backport it to the various release branches.
https://github.com/OpenImageIO/oiio/pull/1518 <https://github.com/OpenImageIO/oiio/pull/1518> > On Oct 4, 2016, at 5:24 PM, Eric Tabellion <[email protected]> > wrote: > > Adding a bit of info that went off-list for the public record: The issue > happens when the input .exr file storage is tiled (as opposed to scanline). > > > On Tue, Oct 4, 2016 at 5:19 PM, Larry Gritz <[email protected] > <mailto:[email protected]>> wrote: > Aha! I'm able to reproduce with the image you sent me off-list. > > Weird! > > I'm looking into it. > > > On Tue, Oct 4, 2016 at 5:10 PM, Eric Tabellion <[email protected] > <mailto:[email protected]>> wrote: > clean.exr definitely is a solid color and so is output.tif, so there is no > way to tell if the garbling happened or not. > It doesn't matter... I've got a repro .exr file I can send you that shows the > issue, and although the garbling pattern looks a bit different I'm pretty > sure it's the same issue. > > On Tue, Oct 4, 2016 at 5:04 PM, Larry Gritz <[email protected] > <mailto:[email protected]>> wrote: > wha? clean.exr should definitely be a solid color as a result of the --fill ! > > > On Tue, Oct 4, 2016 at 4:55 PM, Eric Tabellion <[email protected] > <mailto:[email protected]>> wrote: > There is no obvious way to tell if it worked or not: clean.exr is now a > constant color, and the "garbling" looks like some pixel scanline / block > interleaving bug. Looks interesting, a bit like a mix between pixelation and > what you'd get out of rendering on fields. I'll see if I can repro the image > format and send you some non-sensitive useable data. > > On Tue, Oct 4, 2016 at 4:13 PM, Larry Gritz <[email protected] > <mailto:[email protected]>> wrote: > Does this work? > > oiiotool secret.exr -fill:color=.1,.2,.3,1 4096x4096 -o clean.exr > oiiotool clean.exr --ch "R" --dither --colorconvert linear sRGB -d uint8 -o > output.tif > > does that fail in the same way? > > (I'm trying to coax it into taking whatever's odd with your file, > substituting a color that clobbers all your secret images, and hoping it > still fails in some way so you can send me the file.) > > > On Tue, Oct 4, 2016 at 4:02 PM, Eric Tabellion <[email protected] > <mailto:[email protected]>> wrote: > There is something fishy with our files that is tripping this bug. If I paint > an image in gimp, save it out, convert to an RGB .exr and run it through the > first command, it works just fine. > > Here is what I can say about one of our files that causes the issue: > > iinfo -v input.exr > input.exr : 4096 x 4096, 4 channel, half openexr > channel list: R, G, B, A > tile size: 256 x 256 > oiio:ColorSpace: "Linear" > compression: "zip" > PixelAspectRatio: 1 > screenWindowCenter: 0 0 > screenWindowWidth: 1 > > exrheader input.exr > > file input.exr: > > file format version: 2, flags 0x200 > channels (type chlist): > A, 16-bit floating-point, sampling 1 1 > B, 16-bit floating-point, sampling 1 1 > G, 16-bit floating-point, sampling 1 1 > R, 16-bit floating-point, sampling 1 1 > compression (type compression): zip, multi-scanline blocks > dataWindow (type box2i): (0 0) - (4095 4095) > displayWindow (type box2i): (0 0) - (4095 4095) > lineOrder (type lineOrder): increasing y > pixelAspectRatio (type float): 1 > screenWindowCenter (type v2f): (0 0) > screenWindowWidth (type float): 1 > tiles (type tiledesc): > single level > tile size 256 by 256 pixels > type (type string): "tiledimage" > > > On Tue, Oct 4, 2016 at 3:57 PM, Eric Tabellion <[email protected] > <mailto:[email protected]>> wrote: > # This fails (repeat of my first email) > oiiotool input.exr --ch "R" --dither --colorconvert linear sRGB -d uint8 -o > output.tif > > # This fails too (removing --colorconvert): > oiiotool input.exr --ch "R" --dither -d uint8 -o output.tif > > # This works!!! (removed -d uint8). But then my colorspace is off... > oiiotool input.exr --ch "R" --dither --colorconvert linear sRGB -o output.tif > > > On Tue, Oct 4, 2016 at 3:47 PM, Larry Gritz <[email protected] > <mailto:[email protected]>> wrote: > If you don't do the --colorcorrect, but you do everything else, do you still > get something garbled? > > > On Tue, Oct 4, 2016 at 3:42 PM, Eric Tabellion <[email protected] > <mailto:[email protected]>> wrote: > Feel free to ignore this request entirely on the maketx side. I realize it's > a version of maketx I modified weeks ago, adding a "--dither" command-line > option (a seemingly trivial addition when looking at the oiiotool code). > > The request for oiiotool holds though. I was able to repro the issue with a > fresh build of the freshly pulled master branch and Release-1.7.7 tag. > > On Tue, Oct 4, 2016 at 2:41 PM, Eric Tabellion <[email protected] > <mailto:[email protected]>> wrote: > I'm using OpenImageIO 1.6.13 but using a slightly modified version with our > own build scripts. Let me try a stock build with a more recent version. > > On Tue, Oct 4, 2016 at 1:37 PM, Larry Gritz <[email protected] > <mailto:[email protected]>> wrote: > Weird. Here is the the last email I sent, right here on the list. But my > previous two replies have not shown up in my inbox. > > >> On Oct 4, 2016, at 1:27 PM, Larry Gritz <[email protected] >> <mailto:[email protected]>> wrote: >> >> The mail server from openimageio.org <http://openimageio.org/> seems at the >> moment to be, if not broken, then at least significantly delaying things in >> the queue. >> >> So resending with Eric directly CC'd so he doesn't think I'm ignoring. >> >> I'm having trouble reproducing. Which version of OIIO are you using? >> >> >> >> >> On Mon, Oct 3, 2016 at 11:40 AM, Eric Tabellion >> <[email protected] <mailto:[email protected]>> wrote: >> Hi, >> >> I'm trying to convert grayscale (half) float linear .exr images into 8-bit >> sRGB render-ready .tx files, while using dithering in the process with >> --dither. >> >> When the input image is 3-channel color data the conversion works fine. >> However when the image is single channel, --dither seems to choke up a >> garbled image. Converting the image from 3-channel down to single channel at >> the same time as using --dither won't work either. >> >> For example either of these two commands below will produce garbled images >> using RGBA inputs: >> >> oiiotool input.exr --ch "R" --dither --colorconvert linear sRGB -d uint8 -o >> output.tif >> >> maketx input.exr --nchannels 1 --dither --colorconvert linear sRGB -d uint8 >> --oiio --compression zip -o output.tx >> >> I'm trying to get this all done in one maketx pass, but so far the only way >> I got this to work is doing this: >> >> oiiotool input.exr --dither --colorconvert linear sRGB -d uint8 -o tmp.tif >> maketx tmp.tif --nchannels 1 --oiio --compression zip -o output.tx >> >> This doesn't work though if the input image is already single-channel. >> Anyone else can reproduce this ? Could this be a --dither bug when dithering >> single channel images? >> >> Thanks! >> Eric >> >> -- >> --------------------------------------------------------------- >> Eric Tabellion [email protected] <mailto:[email protected]> >> R&D Staff (650)-562-9146 <tel:%28650%29-562-9146> >> PDI/Dreamworks >> >> >> _______________________________________________ >> Oiio-dev mailing list >> [email protected] <mailto:[email protected]> >> http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org >> <http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org> >> >> >> >> >> -- >> Larry Gritz >> [email protected] >> <mailto:[email protected]>_______________________________________________ >> Oiio-dev mailing list >> [email protected] <mailto:[email protected]> >> http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org >> <http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org> > > -- > Larry Gritz > [email protected] <mailto:[email protected]> > > > > > > -- > --------------------------------------------------------------- > Eric Tabellion [email protected] <mailto:[email protected]> > R&D Staff (650)-562-9146 <tel:%28650%29-562-9146> > PDI/Dreamworks > > > > > -- > --------------------------------------------------------------- > Eric Tabellion [email protected] <mailto:[email protected]> > R&D Staff (650)-562-9146 <tel:%28650%29-562-9146> > PDI/Dreamworks > > > _______________________________________________ > Oiio-dev mailing list > [email protected] <mailto:[email protected]> > http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org > <http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org> > > > > > -- > Larry Gritz > [email protected] <mailto:[email protected]> > _______________________________________________ > Oiio-dev mailing list > [email protected] <mailto:[email protected]> > http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org > <http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org> > > > > > -- > --------------------------------------------------------------- > Eric Tabellion [email protected] <mailto:[email protected]> > R&D Staff (650)-562-9146 <tel:%28650%29-562-9146> > PDI/Dreamworks > > > > > -- > --------------------------------------------------------------- > Eric Tabellion [email protected] <mailto:[email protected]> > R&D Staff (650)-562-9146 <tel:%28650%29-562-9146> > PDI/Dreamworks > > > _______________________________________________ > Oiio-dev mailing list > [email protected] <mailto:[email protected]> > http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org > <http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org> > > > > > -- > Larry Gritz > [email protected] <mailto:[email protected]> > _______________________________________________ > Oiio-dev mailing list > [email protected] <mailto:[email protected]> > http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org > <http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org> > > > > > -- > --------------------------------------------------------------- > Eric Tabellion [email protected] <mailto:[email protected]> > R&D Staff (650)-562-9146 <tel:%28650%29-562-9146> > PDI/Dreamworks > > > _______________________________________________ > Oiio-dev mailing list > [email protected] <mailto:[email protected]> > http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org > <http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org> > > > > > -- > Larry Gritz > [email protected] <mailto:[email protected]> > _______________________________________________ > Oiio-dev mailing list > [email protected] <mailto:[email protected]> > http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org > <http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org> > > > > > -- > --------------------------------------------------------------- > Eric Tabellion [email protected] <mailto:[email protected]> > R&D Staff (650)-562-9146 <tel:%28650%29-562-9146> > PDI/Dreamworks > > > _______________________________________________ > Oiio-dev mailing list > [email protected] <mailto:[email protected]> > http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org > <http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org> > > > > > -- > Larry Gritz > [email protected] <mailto:[email protected]> > _______________________________________________ > Oiio-dev mailing list > [email protected] <mailto:[email protected]> > http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org > <http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org> > > > > > -- > --------------------------------------------------------------- > Eric Tabellion [email protected] <mailto:[email protected]> > R&D Staff (650)-562-9146 > PDI/Dreamworks > > _______________________________________________ > Oiio-dev mailing list > [email protected] > http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org -- Larry Gritz [email protected]
_______________________________________________ Oiio-dev mailing list [email protected] http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org
