Sorry for the delay, things have been so busy lately! Yes, I agree with your assessment, it looks like it calls itself recursively instead of calling the texture handle version. Interestingly, the analogous pair of functions in the ImageCache class was correct.
I've submitted a PR to fix this (and add a test to catch any regressions): https://github.com/OpenImageIO/oiio/pull/1669 I'll backport the fix as well, to whatever versions still seem to contain the problem. Thanks so much for the alert. I guess this particular API call is not widely used (maybe everybody uses the equivalent one in ImageCache?), and apparently was not well represented in the testsuite. -- lg > On Mar 30, 2017, at 8:05 AM, Simon Smith <[email protected]> wrote: > > Hi guys, > > I’m using 1.7.10 and the call to TextureSystem get_texels(ustring filename > ….) call and it seems to just recurses infinitely into itself. > > Looking at the codebase, should the last return get_texels(…) call actually > be calling the TextureHandle version since it’s gone into the cache to get > the TextureFile pointer to check it exists and can presumably grab a handle > from there? > > It’s quite possible I’m using it incorrectly, but thought I’d just ask first. > Previous versions of OIIO have not had this problem, but that was back with > version 1.5.16 and I can see that it has changed somewhat since that version! > > > Cheers, > Simon > _______________________________________________ > Oiio-dev mailing list > [email protected] > http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org -- Larry Gritz [email protected] _______________________________________________ Oiio-dev mailing list [email protected] http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org
