> On Dec. 19, 2011, 7:12 p.m., Albert Astals Cid wrote: > > ui/pageview.cpp, line 3646 > > <http://git.reviewboard.kde.org/r/103424/diff/3/?file=43585#file43585line3646> > > > > Wouldn't this just be > > const bool facingPages = facing || centerFirstPage; > > ?
No, because if overrideCentering is enabled, then it doesn't matter whether facing mode is specified or not; it is disabled. Your fix includes the possibility that overrideCentering may be true (which forces centerFirstPage to be false), yet facing will still be true (because of the ||). But this should never happen, since overrideCentering *always* overrides any facing mode. - Stephen ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103424/#review9096 ----------------------------------------------------------- On Dec. 17, 2011, 11:16 p.m., Stephen Anthony wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103424/ > ----------------------------------------------------------- > > (Updated Dec. 17, 2011, 11:16 p.m.) > > > Review request for Okular. > > > Description > ------- > > This patch improves 'facing pages (center first page)' mode in the case where > a document consists of only 1 or 2 pages. Currently, this mode always > assumes two columns of output (which makes sense for 'facing pages'). > However, in the case of 1 or 2 page documents, the pages are sized according > to two columns, when only one column will ever be used (because of the number > of pages present), resulting in pages that don't fill the page in 'Fit to > Page' view mode. > > Basically, this patch overrides facing pages in such a case and uses one > virtual column, allowing the page to take all available space. > > > Diffs > ----- > > ui/pageview.cpp 78a007a > > Diff: http://git.reviewboard.kde.org/r/103424/diff/diff > > > Testing > ------- > > Testing was done on 1, 2, 3, many page documents in all modes and views. > This patch addresses the specific case where 'facing pages (center first > page)' is enabled AND the pagecount is 2 or less. > > > Thanks, > > Stephen Anthony > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
