----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103424/#review9129 -----------------------------------------------------------
This review has been submitted with commit a6dba2434f93122ee4a506c68ce7222990da4801 by Stephen Anthony to branch KDE/4.8. - Commit Hook On Dec. 19, 2011, 10:57 p.m., Stephen Anthony wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103424/ > ----------------------------------------------------------- > > (Updated Dec. 19, 2011, 10:57 p.m.) > > > Review request for Okular. > > > Description > ------- > > This patch improves 'facing pages (center first page)' mode in the case where > a document consists of only 1 or 2 pages. Currently, this mode always > assumes two columns of output (which makes sense for 'facing pages'). > However, in the case of 1 or 2 page documents, the pages are sized according > to two columns, when only one column will ever be used (because of the number > of pages present), resulting in pages that don't fill the page in 'Fit to > Page' view mode. > > Basically, this patch overrides facing pages in such a case and uses one > virtual column, allowing the page to take all available space. > > > Diffs > ----- > > ui/pageview.cpp 78a007a > > Diff: http://git.reviewboard.kde.org/r/103424/diff/diff > > > Testing > ------- > > Testing was done on 1, 2, 3, many page documents in all modes and views. > This patch addresses the specific case where 'facing pages (center first > page)' is enabled AND the pagecount is 2 or less. > > > Thanks, > > Stephen Anthony > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
