> On Dec. 27, 2012, 3:22 p.m., Fabio D'Urso wrote: > > core/document.cpp, line 2016 > > <http://git.reviewboard.kde.org/r/107442/diff/2/?file=97032#file97032line2016> > > > > We need to check that uc is a TranslateAnnotationCommand too, don't we? > > (see example at > > http://qt-project.org/doc/qt-4.8/qundocommand.html#mergeWith)
Sorry, just read the doc again. Even tough the example code seems to suggest this check is needed, it's not necessary. - Fabio ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107442/#review24050 ----------------------------------------------------------- On Dec. 1, 2012, 9:33 p.m., Jon Mease wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107442/ > ----------------------------------------------------------- > > (Updated Dec. 1, 2012, 9:33 p.m.) > > > Review request for Okular. > > > Description > ------- > > This patch is a first cut at adding undo/redo support to Okular. This patch > is not yet complete, however it is far enough along that I would like to > begin incorporating feedback from the community. > > Functionality: > The following actions can be undone and redone: creation and removal of > annotations, editing arbitrary annotation properties, relocating annotations > with Ctrl+drag, and editing the text contents of an annotation. > > This patch does not yet include support for undoing and redoing editing > actions on forms. I plan to implement this form undo functionality before > the functionality of this patch is included in Okular. > > Known Issue: > When editing an annotation's properties in a .dvi file the annotation is > altered and the action can be undone as expected. However, when editing an > annotation's properties in a .pdf file the image of the original annotation > is not removed from the document when the altered annotation appears. I > would appreciate any possible leads on this issue. > > > > This addresses bug 177501. > http://bugs.kde.org/show_bug.cgi?id=177501 > > > Diffs > ----- > > core/annotations.h 72abdff > core/annotations.cpp 49ab5bd > core/document.h 1d825e1 > core/document.cpp 3e4e21a > core/document_p.h 4a20561 > core/page.cpp 4df58e0 > part.rc 39c1571 > ui/annotationpropertiesdialog.cpp 4b02258 > ui/annotwindow.h f7df9f6 > ui/annotwindow.cpp c1bafb9 > ui/pageview.cpp e5ec39b > > Diff: http://git.reviewboard.kde.org/r/107442/diff/ > > > Testing > ------- > > I have tested the undoing and redoing of the specified annotation actions > using .dvi and .pdf documents. The only known issue is the one described > above when using .pdf files. > > > Thanks, > > Jon Mease > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel