-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107442/
-----------------------------------------------------------
(Updated Feb. 2, 2013, 6:58 p.m.)
Review request for Okular.
Changes
-------
This update utilizes the KTextEdit::aboutToShowContextMenu signal to replace
the default undo and redo actions in the context menu of the AnnotWindow with
the central undo and redo actions on the document.
This resolves the final issue that I am aware of related to the undo/redo
functionality on annotations.
There is still no support for undo/redo on forms
Description
-------
This patch is a first cut at adding undo/redo support to Okular. This patch is
not yet complete, however it is far enough along that I would like to begin
incorporating feedback from the community.
Functionality:
The following actions can be undone and redone: creation and removal of
annotations, editing arbitrary annotation properties, relocating annotations
with Ctrl+drag, and editing the text contents of an annotation.
This patch does not yet include support for undoing and redoing editing actions
on forms. I plan to implement this form undo functionality before the
functionality of this patch is included in Okular.
Known Issue:
When editing an annotation's properties in a .dvi file the annotation is
altered and the action can be undone as expected. However, when editing an
annotation's properties in a .pdf file the image of the original annotation is
not removed from the document when the altered annotation appears. I would
appreciate any possible leads on this issue.
This addresses bug 177501.
http://bugs.kde.org/show_bug.cgi?id=177501
Diffs (updated)
-----
ui/pageview.cpp 60a273d
ui/annotwindow.cpp c1bafb9
ui/annotwindow.h f7df9f6
part.rc 39c1571
ui/annotationpropertiesdialog.cpp 4b02258
core/page.cpp 4df58e0
core/document.cpp 372af56
core/document_p.h 57a3bee
core/document.h 1d825e1
core/annotations.h 72abdff
core/annotations.cpp 49ab5bd
Diff: http://git.reviewboard.kde.org/r/107442/diff/
Testing
-------
I have tested the undoing and redoing of the specified annotation actions using
.dvi and .pdf documents. The only known issue is the one described above when
using .pdf files.
Thanks,
Jon Mease
_______________________________________________
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
