> On Feb. 23, 2013, 8:25 p.m., Bogdan Cristea wrote: > > It crashes while opening pdf or chm files. Below is the crash report for > > pdf file > > > > Application: Okular (okular), signal: Segmentation fault > > Using host libthread_db library "/lib64/libthread_db.so.1". > > [KCrash Handler] > > #5 Okular::DocumentPrivate::searchLowestPriorityPixmap > > (this=this@entry=0x14abf90, unloadableOnly=unloadableOnly@entry=true, > > thenRemoveIt=thenRemoveIt@entry=false, observer=observer@entry=0x0) at > > /home/bogdan/Build/okular/core/document.cpp:426 > > #6 0x00007f0550afeac9 in > > Okular::DocumentPrivate::sendGeneratorPixmapRequest > > (this=this@entry=0x14abf90) at > > /home/bogdan/Build/okular/core/document.cpp:1140 > > #7 0x00007f0550aff5d7 in Okular::DocumentPrivate::requestDone > > (this=0x14abf90, req=0x18cf6c0) at > > /home/bogdan/Build/okular/core/document.cpp:4182 > > #8 0x00007f0550b117b6 in > > Okular::GeneratorPrivate::pixmapGenerationFinished (this=0x1865540) at > > /home/bogdan/Build/okular/core/generator.cpp:108 > > #9 0x00007f055d3e70ae in QObject::event(QEvent*) () from > > /usr/lib64/libQtCore.so.4 > > #10 0x00007f055e02974c in QApplicationPrivate::notify_helper(QObject*, > > QEvent*) () from /usr/lib64/libQtGui.so.4 > > #11 0x00007f055e02dc7a in QApplication::notify(QObject*, QEvent*) () from > > /usr/lib64/libQtGui.so.4 > > #12 0x00007f055ed3d006 in KApplication::notify(QObject*, QEvent*) () from > > /usr/lib64/libkdeui.so.5 > > #13 0x00007f055d3d273e in QCoreApplication::notifyInternal(QObject*, > > QEvent*) () from /usr/lib64/libQtCore.so.4 > > #14 0x00007f055d3d6091 in > > QCoreApplicationPrivate::sendPostedEvents(QObject*, int, QThreadData*) () > > from /usr/lib64/libQtCore.so.4 > > #15 0x00007f055d4007a3 in ?? () from /usr/lib64/libQtCore.so.4 > > #16 0x00007f05595553b5 in g_main_context_dispatch () from > > /usr/lib64/libglib-2.0.so.0 > > #17 0x00007f05595556e8 in ?? () from /usr/lib64/libglib-2.0.so.0 > > #18 0x00007f05595557a4 in g_main_context_iteration () from > > /usr/lib64/libglib-2.0.so.0 > > #19 0x00007f055d400936 in > > QEventDispatcherGlib::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) > > () from /usr/lib64/libQtCore.so.4 > > #20 0x00007f055e0c98ae in ?? () from /usr/lib64/libQtGui.so.4 > > #21 0x00007f055d3d173f in > > QEventLoop::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) () from > > /usr/lib64/libQtCore.so.4 > > #22 0x00007f055d3d19c8 in > > QEventLoop::exec(QFlags<QEventLoop::ProcessEventsFlag>) () from > > /usr/lib64/libQtCore.so.4 > > #23 0x00007f055d3d63a8 in QCoreApplication::exec() () from > > /usr/lib64/libQtCore.so.4 > > #24 0x000000000040887e in main (argc=<optimized out>, argv=<optimized out>) > > at /home/bogdan/Build/okular/shell/main.cpp:94 > >
Right, was using the wrong observer here, has to be p->observer instead of observer to mimic what the old code did, wonder why wasn't crashing here - Albert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109115/#review27941 ----------------------------------------------------------- On Feb. 23, 2013, 10:25 p.m., Albert Astals Cid wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109115/ > ----------------------------------------------------------- > > (Updated Feb. 23, 2013, 10:25 p.m.) > > > Review request for Okular, Aaron J. Seigo, Bogdan Cristea, and Marco Martin. > > > Description > ------- > > Make observer.h installable > > To make sense in doing that kill the harcoded observer ids, move the > priorities to an okular-ui only place and make the pixmap preload easier to > access (not depend on random priority values) > > We need the m_tiledObserver hack since we only support one tiled observer in > the code. > > Also kill viewId from View since doesn't make sense either and is unused :-) > > Note, there are twohtml pages in the "view diff" page > > Marco, Aaron, I haven't tried the active part, could you give it a quick try? > > Superceeds https://git.reviewboard.kde.org/r/107047/ > > > Diffs > ----- > > ui/toc.cpp bde7c97 > ui/minibar.h 185adff > ui/pagepainter.h 42a7313 > ui/pagepainter.cpp 91ae211 > ui/pagesizelabel.h 7c4a1e2 > ui/pageview.h d8a7653 > ui/pageview.cpp 60a273d > ui/presentationwidget.h 1608ef8 > ui/presentationwidget.cpp 35b9d34 > ui/priorities.h PRE-CREATION > ui/side_reviews.h bbd8324 > ui/side_reviews.cpp a35f9ed > ui/thumbnaillist.h 20c434f > ui/thumbnaillist.cpp f191274 > ui/toc.h 8679648 > ui/bookmarklist.h cb8fcc3 > ui/bookmarklist.cpp e1b3869 > active/components/pageitem.cpp a04a8dc > active/components/pageitem.h 0db4080 > active/components/documentitem.cpp 404d863 > active/components/documentitem.h 750e5af > CMakeLists.txt e40cfd6 > core/rotationjob_p.h 305e2a1 > core/rotationjob.cpp e26bd6b > core/page_p.h 75575a7 > core/page.cpp 4df58e0 > core/page.h 6bc60c5 > core/observer.h f7189be > core/generator_p.h 66d4574 > core/generator.cpp 402c881 > core/generator.h 420bd41 > core/document_p.h 57a3bee > core/document.h 1d825e1 > core/document.cpp 372af56 > core/bookmarkmanager.cpp accd65f > ui/annotationmodel.cpp d6d234d > part.h e3a9418 > part.cpp f1cdc11 > generators/spectre/generator_ghostview.cpp d687d01 > generators/chm/generator_chm.cpp c342a10 > generators/chm/generator_chm.h d87071a > core/view.h d1fa376 > > Diff: http://git.reviewboard.kde.org/r/109115/diff/ > > > Testing > ------- > > Compiles, after some tests doesn't seem to crash. > > > Thanks, > > Albert Astals Cid > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
