----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109115/#review28036 -----------------------------------------------------------
"Also kill viewId from View since doesn't make sense either and is unused :-)" Unused there... but not in downstream, at least the Calligra ODP plugin for Okular now fails to build, cmp. http://build.kde.org/job/calligra_master/814/console Any proposal how the relevant code should be done now? https://projects.kde.org/projects/calligra/repository/revisions/master/entry/extras/okularodpgenerator/OkularOdpGenerator.cpp#L125 Cheers Friedrich - Friedrich W. H. Kossebau On Feb. 23, 2013, 10:25 p.m., Albert Astals Cid wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109115/ > ----------------------------------------------------------- > > (Updated Feb. 23, 2013, 10:25 p.m.) > > > Review request for Okular, Aaron J. Seigo, Bogdan Cristea, and Marco Martin. > > > Description > ------- > > Make observer.h installable > > To make sense in doing that kill the harcoded observer ids, move the > priorities to an okular-ui only place and make the pixmap preload easier to > access (not depend on random priority values) > > We need the m_tiledObserver hack since we only support one tiled observer in > the code. > > Also kill viewId from View since doesn't make sense either and is unused :-) > > Note, there are twohtml pages in the "view diff" page > > Marco, Aaron, I haven't tried the active part, could you give it a quick try? > > Superceeds https://git.reviewboard.kde.org/r/107047/ > > > Diffs > ----- > > ui/toc.cpp bde7c97 > ui/minibar.h 185adff > ui/pagepainter.h 42a7313 > ui/pagepainter.cpp 91ae211 > ui/pagesizelabel.h 7c4a1e2 > ui/pageview.h d8a7653 > ui/pageview.cpp 60a273d > ui/presentationwidget.h 1608ef8 > ui/presentationwidget.cpp 35b9d34 > ui/priorities.h PRE-CREATION > ui/side_reviews.h bbd8324 > ui/side_reviews.cpp a35f9ed > ui/thumbnaillist.h 20c434f > ui/thumbnaillist.cpp f191274 > ui/toc.h 8679648 > ui/bookmarklist.h cb8fcc3 > ui/bookmarklist.cpp e1b3869 > active/components/pageitem.cpp a04a8dc > active/components/pageitem.h 0db4080 > active/components/documentitem.cpp 404d863 > active/components/documentitem.h 750e5af > CMakeLists.txt e40cfd6 > core/rotationjob_p.h 305e2a1 > core/rotationjob.cpp e26bd6b > core/page_p.h 75575a7 > core/page.cpp 4df58e0 > core/page.h 6bc60c5 > core/observer.h f7189be > core/generator_p.h 66d4574 > core/generator.cpp 402c881 > core/generator.h 420bd41 > core/document_p.h 57a3bee > core/document.h 1d825e1 > core/document.cpp 372af56 > core/bookmarkmanager.cpp accd65f > ui/annotationmodel.cpp d6d234d > part.h e3a9418 > part.cpp f1cdc11 > generators/spectre/generator_ghostview.cpp d687d01 > generators/chm/generator_chm.cpp c342a10 > generators/chm/generator_chm.h d87071a > core/view.h d1fa376 > > Diff: http://git.reviewboard.kde.org/r/109115/diff/ > > > Testing > ------- > > Compiles, after some tests doesn't seem to crash. > > > Thanks, > > Albert Astals Cid > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel