> On March 26, 2013, 10:54 p.m., Albert Astals Cid wrote: > > core/document.cpp, line 3239 > > <http://git.reviewboard.kde.org/r/107442/diff/7/?file=121230#file121230line3239> > > > > wondering if we should assert here that > > d->m_prevPropsOfAnnotBeingModified is null/empty/wathever > > Jon Mease wrote: > Sure, that makes sense. Is a C++ assert statement sufficient? Or would > you prefer another failure mechanism? > > Albert Astals Cid wrote: > Q_ASSERT (that will only assert in debug builds, otherwise it's a noop) + > if + kWarning like you do in modifyPageAnnotationProperties, also might make > sense adding the Q_ASSERT to modifyPageAnnotationProperties
Ok, sounds good. - Jon ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107442/#review29929 ----------------------------------------------------------- On March 27, 2013, 12:10 p.m., Jon Mease wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107442/ > ----------------------------------------------------------- > > (Updated March 27, 2013, 12:10 p.m.) > > > Review request for Okular. > > > Description > ------- > > This patch adds undo/redo support to Okular's annotation manipulation > commands. > > Functionality: > The following actions can be undone and redone: creation and removal of > annotations, editing arbitrary annotation properties, relocating annotations > with Ctrl+drag, and editing the text contents of an annotation. > > This patch does not include support for undoing and redoing editing actions > on forms. > > > > > This addresses bug 177501. > http://bugs.kde.org/show_bug.cgi?id=177501 > > > Diffs > ----- > > core/annotations.h 72abdff > core/annotations.cpp 49ab5bd > core/annotations_p.h 221572d > core/document.h 6ff6536 > core/document.cpp 5ab759e > core/document_p.h fb3aec6 > core/page.cpp 1db2763 > part.rc 39c1571 > ui/annotationpropertiesdialog.cpp 4b02258 > ui/annotwindow.h f7df9f6 > ui/annotwindow.cpp c1bafb9 > ui/guiutils.h 2ae4ab3 > ui/guiutils.cpp 1d67d3a > ui/pageview.cpp b018dfe > > Diff: http://git.reviewboard.kde.org/r/107442/diff/ > > > Testing > ------- > > I have tested the undoing and redoing of the specified annotation actions > using .dvi and .pdf documents. > > > Thanks, > > Jon Mease > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel