-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107442/
-----------------------------------------------------------
(Updated April 5, 2013, 12:29 a.m.)
Review request for Okular.
Changes
-------
I have removed the QMaps from Document that were used to cache the previous
cursor and anchor positions for the contents of all annotations. This
responsibility now lies with the annotWindow class.
Document::editPageAnnotationContentsOrCursor has been renamed to
Document::editPageAnnotationContents as it should now only be called if the
contents themselves have changed. The previous cursor and anchor positions
have been added to this method signature.
I also made a few small updates to EditTextCommand to prevent consecutive edits
involving the insertion or deletiion newlines from being merged together into a
single undo command. This is to be consistent with the undo behavior of other
text editors like Kate.
Description
-------
This patch adds undo/redo support to Okular's annotation manipulation commands.
Functionality:
The following actions can be undone and redone: creation and removal of
annotations, editing arbitrary annotation properties, relocating annotations
with Ctrl+drag, and editing the text contents of an annotation.
This patch does not include support for undoing and redoing editing actions on
forms.
This addresses bug 177501.
http://bugs.kde.org/show_bug.cgi?id=177501
Diffs (updated)
-----
core/annotations.h 72abdff
core/annotations.cpp 49ab5bd
core/annotations_p.h 221572d
core/document.h 6ff6536
core/document.cpp 5ab759e
core/document_p.h fb3aec6
core/page.cpp 1db2763
part.rc 39c1571
ui/annotationpropertiesdialog.cpp 4b02258
ui/annotwindow.h f7df9f6
ui/annotwindow.cpp c1bafb9
ui/guiutils.h 2ae4ab3
ui/guiutils.cpp 1d67d3a
ui/pageview.cpp b018dfe
Diff: http://git.reviewboard.kde.org/r/107442/diff/
Testing
-------
I have tested the undoing and redoing of the specified annotation actions using
.dvi and .pdf documents.
Thanks,
Jon Mease
_______________________________________________
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
