Would you like to see my final proposal before I submit ? Cheers, Jaydeep
On Mon, Apr 22, 2013 at 9:27 AM, Jaydeep Solanki <jayd...@gmail.com> wrote: > > > > On Mon, Apr 22, 2013 at 2:54 AM, Albert Astals Cid <aa...@kde.org> wrote: > >> El Dissabte, 20 d'abril de 2013, a les 18:07:20, Jaydeep Solanki va >> escriure: >> > I would go for webkit, because as HTML develops webkit developers will >> > improve it where as in QTextDocument case it's not sure that it will >> come >> > up with the latest standards. Or if we try to improve it and maintain >> it, >> > the maintenance load will increase. >> > Also I looked at other ePub viewers such as calibre and it too uses >> webkit. >> > >> > I did some tests and webkit seems to be working out of the box. >> >> What do you mean with "some tests"? >> > I wrote a small test app, that renders epub using webkit, it works well, > as expected. > And for the QTextDocument one I edited Okular source, to see if small > tricks like setting the 'whole html' again when any css property for body > tag appears, worked? But it was not efficient and as such it was a > workaround not the proper way of doing it, which would lead to adding more > such workarounds when more bugs of such kind arise.So I finally settled on > webkit. > > >> >> > BTW, I had a doubt, as currently every generator gives a QTextDocument, >> do >> > we have to change all of the generators to make it work with webkit, or >> > just the specific ePub one ? >> >> What do you think? >> > I think it should be only the ePub generator, because if it's otherwise, I > guess I have a lot to do this summer :-) > > I also wanted to ask, if it is fine if I submit my proposal as soon as the > student application period starts? which is probably less than 24 hours > from now. > > Cheers, > Jaydeep > > >> Cheers, >> Albert >> >> > >> > Cheers, >> > Jaydeep >> > >> > On Fri, Apr 19, 2013 at 2:54 AM, Albert Astals Cid <aa...@kde.org> >> wrote: >> > > El Dijous, 18 d'abril de 2013, a les 23:49:00, Jaydeep Solanki va >> escriure: >> > > > Incase my previous mail didn't reach you because of heavy >> attachment, >> > > >> > > here >> > > >> > > > is another one. >> > > > Hello, >> > > > I would be really happy if you can review the proposal that I have >> > > >> > > created. >> > > >> > > > Proposal link : http://db.tt/7pynIIKN >> > > >> > > Looks correct, one way of improving it would be doing some of the >> > > preliminary >> > > work to see if you'd prefer to go the QTextDocument or the Wekbit >> route. >> > > >> > > Cheers, >> > > >> > > Albert >> > > >> > > > Thank you. >> > > > >> > > > Cheers, >> > > > Jaydeep Solanki >> > > >> > > _______________________________________________ >> > > Okular-devel mailing list >> > > Okular-devel@kde.org >> > > https://mail.kde.org/mailman/listinfo/okular-devel >> _______________________________________________ >> Okular-devel mailing list >> Okular-devel@kde.org >> https://mail.kde.org/mailman/listinfo/okular-devel >> > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel