> On July 7, 2013, 10:31 p.m., Albert Astals Cid wrote: > > "The location of the code in pageview.cpp is therefore justified as the > > image and text extract code is located in the same class. However, I agree > > that pageview.cpp is rather large and should be refactored." > > > > That is not true, the the extraction of images and text is properly > > abstracted in the generator class and each file-type backend implements it > > in its own, or do you see the code that handles pdf text extraction in > > pageview.cpp?
So at Akademy we did a BoF about Okular, the decision about this feature was: * It is acceptable to call pdftocairo * The current way of organizing the code is not acceptable, it needs to be a generator supported feature, i.e. there needs to be API in generators so that they can say if they support this feature or not and if they do the code has to be in the generator side * The one second time limit needs to be removed and instead a dialog saying "Exporting" with a cancel button in case the process decides to run forever Do you think you can work in these improvements? Any question on how to proceed? - Albert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111410/#review35702 ----------------------------------------------------------- On July 7, 2013, 10:22 p.m., Thomas Fischer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111410/ > ----------------------------------------------------------- > > (Updated July 7, 2013, 10:22 p.m.) > > > Review request for Okular. > > > Description > ------- > > This patch implements the feature request of bug 321350: if a PDF file is > viewed, the selection tool offers the new extraction method "vector" which > allows to save to a file (PDF, SVG, EPS, PostScript). The crop operation is > performed by calling "pdftocairo" with matching arguments. The resulting file > contains the original PDF file's content without rendering it to a pixmap. > > I am not sure if calling an external program is an acceptable solution for > this problem. However, it is tested if the program is available before > showing the new option. Alternatively, the code of pdftocairo (as part of > poppler) would had to be copied and integrated into Okular increasing the > solution's complexity. I am not aware of a similar solution available using > poppler-qt4 only. Maybe using a QPrinter printing to PDF would have been an > alternative, but again this seemed to be too complex. > > > Diffs > ----- > > ui/pageview.cpp 16b00ab > > Diff: http://git.reviewboard.kde.org/r/111410/diff/ > > > Testing > ------- > > > Thanks, > > Thomas Fischer > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
