----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111410/ -----------------------------------------------------------
(Updated July 23, 2013, 9:24 p.m.) Review request for Okular. Changes ------- This patch refactors the export to be inside the generators. The dialog to cancel does not yet exist. This new implementation hooks into the existing selection extract menu actions and uses the generator instead of the existing general implemenation when possible as the generator-based implemenation may offer more features (more file formats or higher resolutions). Description ------- This patch implements the feature request of bug 321350: if a PDF file is viewed, the selection tool offers the new extraction method "vector" which allows to save to a file (PDF, SVG, EPS, PostScript). The crop operation is performed by calling "pdftocairo" with matching arguments. The resulting file contains the original PDF file's content without rendering it to a pixmap. I am not sure if calling an external program is an acceptable solution for this problem. However, it is tested if the program is available before showing the new option. Alternatively, the code of pdftocairo (as part of poppler) would had to be copied and integrated into Okular increasing the solution's complexity. I am not aware of a similar solution available using poppler-qt4 only. Maybe using a QPrinter printing to PDF would have been an alternative, but again this seemed to be too complex. Diffs (updated) ----- core/document.h fe296e0 core/document.cpp 6731d87 core/generator.h a5a971b core/generator.cpp 41beb92 generators/poppler/generator_pdf.h 5d5853a generators/poppler/generator_pdf.cpp 122ece5 ui/pageview.cpp 16b00ab Diff: http://git.reviewboard.kde.org/r/111410/diff/ Testing ------- Thanks, Thomas Fischer
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
