> On Jan. 27, 2014, 9:42 p.m., Albert Astals Cid wrote: > > "* In scroll mode, now okular can load new page correctly" > > > > What does this mean? > > Yichao Zhou wrote: > It means that the orignal patch in Bugs 219121 will not load new page due > to the guard code in PageView::slotRequestVisiblePixmaps().
Hello! I have implemented an another prototype feature for smooth scroll: https://bugs.kde.org/show_bug.cgi?id=319870 The problem is I need to modify the UI so I can add some configuration. I need to add some configuration under the accessibility configuration page again. But adding it on the master branch will conflict with this one, since git cannot handle UI written in XML. Should I build my smooth scroll patch based on this patch? Maybe we should add another configuration page for "Control Setting" since "Accessibility" is not a very appropriate name for them. - Yichao ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115335/#review48417 ----------------------------------------------------------- On Jan. 28, 2014, 7:02 a.m., Yichao Zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115335/ > ----------------------------------------------------------- > > (Updated Jan. 28, 2014, 7:02 a.m.) > > > Review request for Okular. > > > Bugs: 219121 > http://bugs.kde.org/show_bug.cgi?id=219121 > > > Repository: okular > > > Description > ------- > > According to the comments in https://bugs.kde.org/show_bug.cgi?id=219121, I > implemented that feature with an option in accessibility pages. > > > This patch also fixes some problems in the original patch, and provides more > features, including > * In scroll mode, you can press ctrl key to enter zoom mode > * Now you can use middle key to scroll in all mouse mode (broswer, zoom, > selection, etc.) > * In scroll mode, now okular can load new page correctly > > > Diffs > ----- > > conf/dlgaccessibilitybase.ui 9e76a75 > conf/okular.kcfg deabd07 > ui/pageview.h 9c15af6 > ui/pageview.cpp 65967bf > > Diff: https://git.reviewboard.kde.org/r/115335/diff/ > > > Testing > ------- > > > Thanks, > > Yichao Zhou > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
