----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115532/#review53275 -----------------------------------------------------------
ui/presentationwidget.cpp <https://git.reviewboard.kde.org/r/115532/#comment37474> You new it but never delete it, this is a memory leak. Please fix it. - Albert Astals Cid On Feb. 27, 2014, 9:02 a.m., Saheb Preet Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115532/ > ----------------------------------------------------------- > > (Updated Feb. 27, 2014, 9:02 a.m.) > > > Review request for Okular. > > > Bugs: 317073 > http://bugs.kde.org/show_bug.cgi?id=317073 > > > Repository: okular > > > Description > ------- > > implemented fade in and fade out transition for presentation mode in okular. > > > Diffs > ----- > > ui/presentationwidget.h a99b8ce > ui/presentationwidget.cpp 4aaec2a > > Diff: https://git.reviewboard.kde.org/r/115532/diff/ > > > Testing > ------- > > It works fine on my system accept for the first time in case of fade out > transition. > > > Thanks, > > Saheb Preet Singh > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
