> On July 15, 2014, 4:27 a.m., Albert Astals Cid wrote:
> > I'd say we're still leaking m_currentTransition sometimes, like for example
> >
> > PresentationWidget::slotPrevPage has
> >
> > if ( m_transitionTimer->isActive() )
> > {
> > m_transitionTimer->stop();
> > update();
> > }
> >
> > so the transition step won't be called and m_currentTransition won't be
> > deleted. Isn't it easier if you just make it a member variable instead of a
> > pointer so we don't have to worry about it?
Fixed the above said issues.
Sir I also wanted to ask you something,
its commented in the code // implement missing transitions (a binary raster
engine needed here)
Am I implementing the feature in a right way ?? Is there any other better way
of doing it??
- Saheb
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115532/#review62357
-----------------------------------------------------------
On July 16, 2014, 1:23 p.m., Saheb Preet Singh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115532/
> -----------------------------------------------------------
>
> (Updated July 16, 2014, 1:23 p.m.)
>
>
> Review request for Okular.
>
>
> Bugs: 317073
> http://bugs.kde.org/show_bug.cgi?id=317073
>
>
> Repository: okular
>
>
> Description
> -------
>
> implemented fade in and fade out transition for presentation mode in okular.
>
>
> Diffs
> -----
>
> conf/dlgpresentationbase.ui 31db693
> conf/okular.kcfg f980989
> ui/presentationwidget.h a99b8ce
> ui/presentationwidget.cpp 4aaec2a
>
> Diff: https://git.reviewboard.kde.org/r/115532/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Saheb Preet Singh
>
>
_______________________________________________
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
