----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126183/#review88908 -----------------------------------------------------------
Looks good, but a few minor improvements can be made to docs and comments: find-modules/FindPoppler.cmake (line 11) <https://git.reviewboard.kde.org/r/126183/#comment60888> Space at end find-modules/FindPoppler.cmake (line 20) <https://git.reviewboard.kde.org/r/126183/#comment60889> s/requestion/requested/ find-modules/FindPoppler.cmake (lines 36 - 41) <https://git.reviewboard.kde.org/r/126183/#comment60890> In CMake, it's TRUE and FALSE (all-caps) find-modules/FindPoppler.cmake (line 40) <https://git.reviewboard.kde.org/r/126183/#comment60892> Is this true, given you're using SKIP_PKG_CONFIG? find-modules/FindPoppler.cmake (lines 117 - 118) <https://git.reviewboard.kde.org/r/126183/#comment60891> You used SKIP_PKG_CONFIG, so I doubt this comment is accurate. If you could give us the Okular diff as Albert requested, that would be good, too. - Alex Merry On Nov. 27, 2015, 12:47 p.m., Alex Richardson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126183/ > ----------------------------------------------------------- > > (Updated Nov. 27, 2015, 12:47 p.m.) > > > Review request for Extra Cmake Modules, Okular, Albert Astals Cid, and Tobias > Koenig. > > > Repository: extra-cmake-modules > > > Description > ------- > > At least Okular and KBibTex include a FindPoppler.cmake module but this one > uses the new ECMFindModuleHelpers and has imported targets. > > --- > > To make FindPoppler.cmake work without pkg-config it also includes this > commit: > > > Use PATH_SUFFIXES in ecm_find_package_handle_library_components() > > > This is required to find poppler without package config as all the headers > are installed in a poppler subdirectory of the include directory > > > Diffs > ----- > > find-modules/FindPoppler.cmake PRE-CREATION > modules/ECMFindModuleHelpers.cmake 2044efe1ccf679b738f68aec9b3fb007c449717c > > Diff: https://git.reviewboard.kde.org/r/126183/diff/ > > > Testing > ------- > > Okular can be built using this find module with minor changes. As it doesn't > set various HAVE_POPPLER_0_36 etc. variables that the find module in okular > did, I set those variables in the okular CMakeLists.txt > > > Thanks, > > Alex Richardson > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel