> On Nov. 27, 2015, 9:47 p.m., Alex Merry wrote: > > find-modules/FindPoppler.cmake, lines 117-118 > > <https://git.reviewboard.kde.org/r/126183/diff/1/?file=418633#file418633line117> > > > > You used SKIP_PKG_CONFIG, so I doubt this comment is accurate.
SKIP_PKG_CONFIG shouldn't be there, I just added that to make sure that it works even without pkg-config > On Nov. 27, 2015, 9:47 p.m., Alex Merry wrote: > > find-modules/FindPoppler.cmake, line 20 > > <https://git.reviewboard.kde.org/r/126183/diff/1/?file=418633#file418633line20> > > > > s/requestion/requested/ I copied the documentation from FindWayland.cmake, fixed it there too. On Nov. 27, 2015, 9:47 p.m., Alex Richardson wrote: > > If you could give us the Okular diff as Albert requested, that would be > > good, too. Patch to okular is here: https://paste.kde.org/pi50cclxc It builds and installs and runs fine. - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126183/#review88908 ----------------------------------------------------------- On Nov. 27, 2015, 12:47 p.m., Alex Richardson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126183/ > ----------------------------------------------------------- > > (Updated Nov. 27, 2015, 12:47 p.m.) > > > Review request for Extra Cmake Modules, Okular, Albert Astals Cid, and Tobias > Koenig. > > > Repository: extra-cmake-modules > > > Description > ------- > > At least Okular and KBibTex include a FindPoppler.cmake module but this one > uses the new ECMFindModuleHelpers and has imported targets. > > --- > > To make FindPoppler.cmake work without pkg-config it also includes this > commit: > > > Use PATH_SUFFIXES in ecm_find_package_handle_library_components() > > > This is required to find poppler without package config as all the headers > are installed in a poppler subdirectory of the include directory > > > Diffs > ----- > > find-modules/FindPoppler.cmake PRE-CREATION > modules/ECMFindModuleHelpers.cmake 2044efe1ccf679b738f68aec9b3fb007c449717c > > Diff: https://git.reviewboard.kde.org/r/126183/diff/ > > > Testing > ------- > > Okular can be built using this find module with minor changes. As it doesn't > set various HAVE_POPPLER_0_36 etc. variables that the find module in okular > did, I set those variables in the okular CMakeLists.txt > > > Thanks, > > Alex Richardson > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel