> On Feb. 11, 2016, 9:41 p.m., Armin K. wrote: > > I didn't notice this review request and did porting on my own. My patch > > takes into account some things your doesn't at the moment. Can you port the > > version checks and possibly other changes from my RR to your patch, so I > > can close my review request? > > > > https://git.reviewboard.kde.org/r/127049/ > > Michael Palimaka wrote: > Your patch looks more complete, so I'd suggest using that and closing > this instead.
Well, it's your MR, you can close it as you wish. - Albert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126842/#review92275 ----------------------------------------------------------- On Jan. 22, 2016, 12:31 p.m., Michael Palimaka wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126842/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2016, 12:31 p.m.) > > > Review request for Okular. > > > Repository: okular > > > Description > ------- > > Some small changes are required to ensure build passes with ECM's new > FindPoppler.cmake. > > > Diffs > ----- > > CMakeLists.txt 492de006c58904f0da94f4cfb9e2ca79ab839c45 > cmake/modules/FindPoppler.cmake 80a78627438703a9db4d7cd97649098c41b1b2ce > generators/CMakeLists.txt ce1d9bfeeb401466c47648d1d828fbd2ff4b18f6 > generators/poppler/CMakeLists.txt 740b6fd8d6311bee80845a034bba148d443afbd4 > > Diff: https://git.reviewboard.kde.org/r/126842/diff/ > > > Testing > ------- > > Builds, PDFs still open. > > > Thanks, > > Michael Palimaka > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
