davidhurka added a comment.
Nice, makes the list more intuitive. :) (Didn’t test this) Three questions/suggestions: - Assuming that captionForAnnotation() returns something more useful than “<annotation type> with Comment” (like “<annotation type>: <comment>”), should data() return an "okular" icon by default? If there is no data that can be shown in an icon, the horizontal space could be used for the comment instead. - Maybe data() could return Annotation::icon(), where icon() is a virtual funtion which returns an appropriate, colored QIcon? - Weren’t the list items ordered by y-position once? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21364 To: jangmarker, #okular Cc: davidhurka, okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid
