davidhurka added a comment.
Why do you move EditAnnotToolDialog to GuiUtils? / How does the annotation tool bar (shown with F6) get its icons? I’m not familar with the annotation implementation, but if you move this function arround, I would expect it as virtual function in Annotation, so every annotation can implement icon generation the correct way. (Don’t know how the toolbar would get its icons then...) REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21364 To: jangmarker, #okular Cc: davidhurka, okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid
