On Wed, 13 May 2009, Sebastien Roy wrote: > > On Wed, 2009-05-13 at 08:09 -0700, John Beck wrote: >> Generally: I sympathize and approve of your suggestions. Nits: >> >> >> Sebastien> Logs of automated >> Sebastien> tests, or terminal output of manual tests are welcome. >> >> Change that to "Pointers to ..., along with a high-level summary." I often >> get RTIs with pointers to several test log files that are very long and >> somewhat difficult to parse, so a) putting them in-line is impractical, >> and b) providing an executive summary makes my work a lot easier. > > I agree with you. > >> Sebastien> If tests could be added to an existing automated test suite to >> Sebastien> facilitate in testing the affected code, then either integrate >> Sebastien> such a test, or file an RFE against the test suite detailing >> Sebastien> what is missing. Without that, code-coverage of existing >> Sebastien> test suites will never improve, and bugs will perpetually be >> Sebastien> re-introduced in the same areas due to lack of test coverage. >> >> All true and good suggestions, but in that case, the "T" impact button >> should be selected, and the CR #(s) for new or updated test suites should >> be listed in the Comments section of the RTI. > > Yes indeed. Here's the updated text: > > * Test Results > * This section should contain enough information for the CRT > advocate to evaluate if testing was adequate. Pointers to logs of > automated tests or terminal output of manual tests are welcome, > along with a high-level summary. A statement of the form, "I > tested the code and it passed" is inadequate. > * If tests could be added to a new or existing automated test suite > to facilitate testing of the affected code, then either integrate > such tests, or file an RFE against the test suite detailing what > is missing. In this case the "T" impact button should be > selected, and the CRs for the new or updated test suites should be > listed in the Comments section of the RTI. Without that, > code-coverage of existing test suites will never improve, and bugs > will perpetually be re-introduced in the same areas due to lack of > test coverage.
Hi Seb - Sorry for the delay in following up with you. As you can now see, the RTI nits page has been updated with the language agreed upon with the ON test sponsor folks, which happened before your mail came out. I believe your second bullet is adequately covered in the new nits text, but I don't think the first is fully covered. Could you look at the new text at let me know what, if any, additional testing text you want? Valerie -- Valerie Fenwick, http://blogs.sun.com/bubbva/ @bubbva Solaris Security Technologies, Developer, Sun Microsystems, Inc. 17 Network Circle, Menlo Park, CA, 94025.
