Gavin Maltby wrote:
> Hi,
> 
> A have a few trivial changes to bldenv that I'd like to push
> sometime.  I can't imagine they'd be too controversial but
> I'd like to take this opportunity to ask people to let me know
> if any of the changes would upset the way you use bldenv.
> 
> http://cr.opensolaris.org/~gavinm/bldenv/webrev/
> 
> bldenv should source /etc/nightly.conf as nightly does
> 
>     I source /etc/nightly.conf before the user env file
>     so individual users could still override the
>     choices in /etc/nightly.conf.
> 
>     This change allows build machine maintainers to
>     list things like BUILD_TOOLS in /etc/nightly.conf
>     and individual bldenv users do not have to edit
>     their env file to locate local tools (assuming you're
>     not on SWAN with /ws etc).
> 
> bldenv should set DMAKE_MODE
> 
>     ... to "parallel" to save dmake whining thus
> 
>     dmake: defaulting to parallel mode.
>     See the man page dmake(1) for more information on setting up the 
> .dmakerc file.
> 
>     on every cmdline invocation.
> 
> bldenv should start a new task and honor BUILD_PROJECT
> 
>     The new shell started by bldenv is launched in a new task,
>     and in the project indicated by BUILD_PROJECT if set in
>     the environment (usually user env file but could be
>     /etc/nightly.conf).
> 
>     I point builds to a separate project which has fewer cpu shares
>     to keep the desktop interactive.
> 
> Thanks
> 
> Gavin
> _______________________________________________
> on-discuss mailing list
> on-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/on-discuss

+1

The changes look fine to me.

-tim


Reply via email to