Gavin Maltby wrote: > A have a few trivial changes to bldenv that I'd like to push > sometime. I can't imagine they'd be too controversial but > I'd like to take this opportunity to ask people to let me know > if any of the changes would upset the way you use bldenv. > > http://cr.opensolaris.org/~gavinm/bldenv/webrev/
The changes look good except that it may be nice to use [[ expr ]] instead of [ expr ] (see http://www.opensolaris.org/os/project/shell/shellstyle/ , I already cleaned-up "bldenv.sh" based on that document and it would be nice to keep it that way) BTW: In the future (not _yet_ since it is a new ksh93 feature) it may be usefull to use [[ -v varname ]] instead of [[ -z "$varname" ]] since "-z" form expands "varname" while "-v" simply tests whether the variable exists (and doesn't look at the value). ---- Bye, Roland -- __ . . __ (o.\ \/ /.o) roland.mainz at nrubsig.org \__\/\/__/ MPEG specialist, C&&JAVA&&Sun&&Unix programmer /O /==\ O\ TEL +49 641 3992797 (;O/ \/ \O;)
